fix(output): handle --unix-timestamp flag
#4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergargar
changed the title
--unix-timestamp flag
jfagoagas
requested changes
May 23, 2024
| @@ -29,7 +29,7 @@ class FindingOutput(BaseModel): | |||
| """ | |||
|
|
|||
| auth_method: str | |||
| timestamp: datetime | |||
| timestamp: Union[int, datetime] | |||
There was a problem hiding this comment.
Can you add a test creating a FindingOutput with the unix timestamp?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4079 +/- ##
==========================================
+ Coverage 86.27% 86.29% +0.02%
==========================================
Files 790 790
Lines 24729 24729
==========================================
+ Hits 21335 21340 +5
+ Misses 3394 3389 -5 ☔ View full report in Codecov by Sentry. |
jfagoagas
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #4077
Description
Modify FindingOutput class to make timestamp an int or datetime.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.