Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(output): handle --unix-timestamp flag #4079

Merged
merged 2 commits into from
May 24, 2024
Merged

fix(output): handle --unix-timestamp flag #4079

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b7565b
fix(output): handle --unix-timestamp flag
pedrooot May 23, 2024
c131ece
add tests
pedrooot May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions prowler/lib/outputs/common_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from datetime import datetime
from enum import Enum
from typing import Optional
from typing import Optional, Union

from pydantic import BaseModel

Expand Down Expand Up @@ -29,7 +29,7 @@ class FindingOutput(BaseModel):
"""

auth_method: str
timestamp: datetime
timestamp: Union[int, datetime]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test creating a FindingOutput with the unix timestamp?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

account_uid: str
# Optional since depends on permissions
account_name: Optional[str]
Expand Down