Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the reference to: http://bit.ly/2g3PEf7 #96

Closed
hemedga opened this issue Aug 21, 2017 · 4 comments
Closed

Removing the reference to: http://bit.ly/2g3PEf7 #96

hemedga opened this issue Aug 21, 2017 · 4 comments

Comments

@hemedga
Copy link

hemedga commented Aug 21, 2017

This reference doesn't add much information and may encourage uninformed users to click on unverified links. Whoever is working with the tool should also have the benchmark at hand to understand/handle issues.

I'll be happy to create a pull request for this issue, I'm just not sure how is best to tackle this.
Maybe remove all references from the reports aside from a link at the top of the report.

@toniblyx
Copy link
Member

Thanks @hemedga. Why do you think it may confuse users? The way to understand all these checks are looking at the CIS Benchmark guide. Did I miss something?

@hemedga
Copy link
Author

hemedga commented Aug 21, 2017

From a security standpoint, url shorteners may be used to spread malware and web attacks.
Users click on these links without checking their origin.

I prefer to publish urls which are verified for the source or fully controlled by my organization.

@toniblyx
Copy link
Member

@toniblyx
Copy link
Member

You are right. You can send a PR with the way you consider is better. I would be glad to accept it.

hemedga pushed a commit to hemedga/prowler that referenced this issue Aug 21, 2017
toniblyx added a commit that referenced this issue Aug 22, 2017
Fix issue #96 - remove bit.ly reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants