-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the reference to: http://bit.ly/2g3PEf7 #96
Comments
Thanks @hemedga. Why do you think it may confuse users? The way to understand all these checks are looking at the CIS Benchmark guide. Did I miss something? |
From a security standpoint, url shorteners may be used to spread malware and web attacks. I prefer to publish urls which are verified for the source or fully controlled by my organization. |
got it, you are talking about this: https://github.com/Alfresco/prowler/blob/0e0f3a334e60e57777a65f0eebe7e50900459b8e/prowler#L440 |
You are right. You can send a PR with the way you consider is better. I would be glad to accept it. |
Fix issue #96 - remove bit.ly reference
This reference doesn't add much information and may encourage uninformed users to click on unverified links. Whoever is working with the tool should also have the benchmark at hand to understand/handle issues.
I'll be happy to create a pull request for this issue, I'm just not sure how is best to tackle this.
Maybe remove all references from the reports aside from a link at the top of the report.
The text was updated successfully, but these errors were encountered: