Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamodb_allowlist): Support DynamoDB tables ARN for allowlist input #1118

Merged

Conversation

sergargar
Copy link
Member

Context

Support dynamodb tables arn as an allowlist input.

Description

If the user has a table with account_id as a partition key and rule as a sort key, it can be used as an allowlist for Prowler.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested a review from a team as a code owner April 28, 2022 13:58
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive!!! 👏

if grep -q -E "^s3://([^/]+)/(.*?([^/]+))$" <<< "${ALLOWLIST_FILE}"; then
allowlist_S3
# Check if the file is a DynamoDB ARN
elif grep -q -E "^arn:aws:dynamodb:\w+(?:-\w+)+:\d{12}:table\/[A-Za-z0-9]+$" <<< "${ALLOWLIST_FILE}"; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@jfagoagas jfagoagas changed the title feat(dynamodb_allowlist): Support dynamodb tables arn for allowlist input. feat(dynamodb_allowlist): Support dynamodb tables arn for allowlist input Apr 28, 2022
@jfagoagas jfagoagas changed the title feat(dynamodb_allowlist): Support dynamodb tables arn for allowlist input feat(dynamodb_allowlist): Support DynamoDB tables ARN for allowlist input Apr 28, 2022
@jfagoagas jfagoagas merged commit aa16bf4 into master Apr 28, 2022
@jfagoagas jfagoagas deleted the PRWLR-166-whitelist-support-for-prowler-pro-deployment branch April 28, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants