Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checks): Handle checks not returning result #1383

Conversation

n4ch04
Copy link
Contributor

@n4ch04 n4ch04 commented Oct 5, 2022

Context

There exists some checks that under certain conditions don't return any results

Description

Modify those checks to return results when there are not resources checked:

  • extra72
  • extra74
  • extra729
  • extra7164

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@n4ch04 n4ch04 requested a review from a team as a code owner October 5, 2022 08:10
@jfagoagas jfagoagas force-pushed the PRWLR-890-review-prowler-2-x-checks-not-included-in-saa-s-results branch from 8eaf11c to 2223159 Compare October 5, 2022 08:12
@jfagoagas jfagoagas changed the title Review checks not returning result fix(checks): Handle checks not returning result Oct 5, 2022
@jfagoagas jfagoagas force-pushed the PRWLR-890-review-prowler-2-x-checks-not-included-in-saa-s-results branch from 2223159 to 8036283 Compare October 5, 2022 08:14
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @n4ch04, good job!!

@n4ch04 n4ch04 merged commit 11cc8e9 into master Oct 5, 2022
@n4ch04 n4ch04 deleted the PRWLR-890-review-prowler-2-x-checks-not-included-in-saa-s-results branch October 5, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants