fix(browser auth): fix browser auth in Azure to include tenant id #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
requested changes
May 29, 2023
prowler/lib/cli/parser.py
Outdated
Comment on lines
448
to
453
| azure_parser.add_argument( | ||
| "--tenant-id", | ||
| nargs="+", | ||
| default=[], | ||
| help="Azure tenant id to be used with --browser-auth option", | ||
| ) |
There was a problem hiding this comment.
Why this variable is a list? If we need to pass a list of tenants please change it to --tenant-ids and change the description accordingly.
| @@ -59,7 +60,14 @@ def __set_credentials__( | |||
| ) | |||
| sys.exit(1) | |||
| else: | |||
| credentials = InteractiveBrowserCredential() | |||
| try: | |||
| credentials = InteractiveBrowserCredential(tenant_id=tenant_id[0]) | |||
There was a problem hiding this comment.
See comment about the --tenant-id.
jfagoagas
changed the title
jfagoagas
reviewed
Jun 2, 2023
jfagoagas
reviewed
Jun 2, 2023
jfagoagas
approved these changes
Jun 2, 2023
jfagoagas
deleted the
PRWLR-2110-bug-prowler-browser-auth-issue-on-azure-provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Browser auth in azure was failing under certain circunstancies. It looked like it was related with the tenant id assumed as default
Description
Modify the browser auth mode to include the tenant id as argument
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.