fix(security hub): Adds logic to map to valid ASFF statuses #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckdake
changed the title
sergargar
reviewed
Jun 15, 2023
Co-authored-by: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
sergargar
approved these changes
Jun 15, 2023
|
Hmm, test failed. It doesn't look to be related since the check looks like it's happening before ASFF? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When running prowler against our AWS infrastructure, reporting using ASFF to security hub, we are unable to report all results due to "Status" being set incorrectly in API requests to Security Hub.
Description
AWS publishes the list of allowed values for Compliance Status here: https://docs.aws.amazon.com/securityhub/1.0/APIReference/API_Compliance.html. This PR replaces blind
+ "ED"text manipulation with a condition that maps the output of prowler into values accepted by Security Hub.We currently see "WARNINGED" and "INFOED", after this PR we will see "WARNING" and "INFO". We are not currently seeing any statuses that will map to "NOT_AVAILABLE", but this should cover other AWS situations that are beyond the scope of my test runs here.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.