fix(asff): handle empty Recommendation Url #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n4ch04
reviewed
Jun 15, 2023
| @@ -78,6 +78,9 @@ def fill_json_asff(finding_output, audit_info, finding, output_options): | |||
| AssociatedStandards=associated_standards, | |||
| RelatedRequirements=compliance_summary, | |||
| ) | |||
| # Fill Recommendation Url if it is blank | |||
| if not finding.check_metadata.Remediation.Recommendation.Url: | |||
There was a problem hiding this comment.
Could you create a test for this case please?
There was a problem hiding this comment.
We cannot create it since moto does not cover this call and we cannot mock the call twice.
There was a problem hiding this comment.
This has nothing to do with Moto, is just a test for the fill_asff_json. I'm finishing it and I'll push it later today.
jfagoagas
force-pushed
the
2492-bug-unable-to-push-findings-to-security-hub-when-recommendation-url-is-blank
branch
from
058bf25
to
c328c48
Compare
sergargar
deleted the
2492-bug-unable-to-push-findings-to-security-hub-when-recommendation-url-is-blank
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle empty Recommendation Url since Security Hub does not accept them empty.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.