fix(security hub): solve Security Hub format requirements #2520
Conversation
prowler/lib/outputs/json.py
Outdated
| # Description should NOT be longer than 1024 characters | ||
| finding_output.Description = ( | ||
| (finding.status_extended[:1000] + "..") | ||
| if len(finding.status_extended) > 100 | ||
| else finding.status_extended | ||
| ) |
There was a problem hiding this comment.
Could you include this as a part of the class validator? It's so easy to do it with Pydantic https://docs.pydantic.dev/latest/usage/validators/
There was a problem hiding this comment.
Also, you are doing the comparison with 100 as length.
There was a problem hiding this comment.
Why do I need validators? I want to change the field, not to validate it.
There was a problem hiding this comment.
Because you are doing a validation checking the field length, also with that you have all the logic to build the model within the class since you can do that:
class JSONASFF(BaseModel):
Description: str
@validator('Description')
def description_sould_not_exceed_1024_chars(cls, value):
if len(value) > 1000:
return value[:1000] + ".."There was a problem hiding this comment.
Also, please include tests that validates the new logic included
| if ( | ||
| len(associated_standards) < 20 | ||
| ): # AssociatedStandards should NOT have more than 20 items | ||
| associated_standards.append({"StandardsId": key}) | ||
| item = f"{key} {' '.join(value)}" | ||
| if len(item) > 64: | ||
| item = item[0:63] | ||
| compliance_summary.append(item) |
There was a problem hiding this comment.
Could you include this as a part of the class validator? It's so easy to do it with Pydantic https://docs.pydantic.dev/latest/usage/validators/
sergargar
force-pushed
the
2519-bug-additional-output-formats-causing-errors-reporting-to-security-hub-preventing-findings-from-being-recorded
branch
3 times, most recently
from
b660a46
to
2ce8a18
Compare
sergargar
force-pushed
the
2519-bug-additional-output-formats-causing-errors-reporting-to-security-hub-preventing-findings-from-being-recorded
branch
from
2ce8a18
to
1d6ab73
Compare
jfagoagas
deleted the
2519-bug-additional-output-formats-causing-errors-reporting-to-security-hub-preventing-findings-from-being-recorded
branch
Description
Solve Security Hub format requirements:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.