chore(ec2): reduce noise in Security Groups checks #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergargar
force-pushed
the
reduce-sg-noise
branch
from
de479ed
to
f882ca5
Compare
jfagoagas
requested changes
Jun 23, 2023
jfagoagas
requested changes
Jun 23, 2023
| @@ -34,6 +35,15 @@ def set_mocked_audit_info(self): | |||
| organizations_metadata=None, | |||
| audit_resources=None, | |||
| mfa_enabled=False, | |||
| audit_metadata=Audit_Metadata( | |||
| services_scanned=0, | |||
| # We need to set this check to call __list_functions__ | |||
There was a problem hiding this comment.
Suggested change
| # We need to set this check to call __list_functions__ | |
| # We need to set this check to call __list_functions__ |
| @@ -46,6 +47,15 @@ def set_mocked_audit_info(self): | |||
| organizations_metadata=None, | |||
| audit_resources=None, | |||
| mfa_enabled=False, | |||
| audit_metadata=Audit_Metadata( | |||
| services_scanned=0, | |||
| # We need to set this check to call __list_functions__ | |||
There was a problem hiding this comment.
Suggested change
| # We need to set this check to call __list_functions__ |
jfagoagas
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce noise in Security Groups checks (if a security group has all ports open, only create one finding).
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.