Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudwatch secrets): fix nonetype error handling #2543

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix(cloudwatch secrets): fix nonetype error handling #2543

merged 1 commit into from
Jul 3, 2023

Conversation

n4ch04
Copy link
Contributor

@n4ch04 n4ch04 commented Jul 3, 2023

Context

Check cloudwatch_log_group_no_secrets_in_logs was failing under certain conditions

ERROR: cloudwatch_log_group_no_secrets_in_logs -- TypeError[60]: 'NoneType' object is not iterable

Description

Handle when call to detect_secrets_scan in cloudwatch_log_group_no_secrets_in_logs returns None

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@n4ch04 n4ch04 requested a review from a team as a code owner July 3, 2023 09:38
jfagoagas
jfagoagas approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jfagoagas jfagoagas merged commit 6403fea into master Jul 3, 2023
4 checks passed
@jfagoagas jfagoagas deleted the fix-cloudwatch-secrets-check branch July 3, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfagoagas jfagoagas jfagoagas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n4ch04 @jfagoagas