feat(cond parser): add policy cond parser & apply in sqs public check #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
requested changes
Jul 12, 2023
...rs/aws/services/sqs/sqs_queues_not_publicly_accessible/sqs_queues_not_publicly_accessible.py
Outdated
Show resolved
Hide resolved
...rs/aws/services/sqs/sqs_queues_not_publicly_accessible/sqs_queues_not_publicly_accessible.py
Outdated
Show resolved
Hide resolved
n4ch04
force-pushed
the
sqs-queue-policy-condition
branch
from
f66ec77
to
0986a95
Compare
n4ch04
force-pushed
the
sqs-queue-policy-condition
branch
2 times, most recently
from
0992904
to
0b39247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
From #2565
We need to be able to parse condition blocks from IAM policies to apply it in several checks, in this case we need to be able to test if a sqs queue is public or not
Description
Adds a new lib with a condition block parser and apply it in check
sqs_queues_not_publicly_accessibleLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.