Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(allowlist): single account checks handling #2585

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

n4ch04
Copy link
Contributor

@n4ch04 n4ch04 commented Jul 13, 2023

Context

Fix #2584

Allowlist feature was not working properly when a single account was the only entry of the allowlist.yaml file

Description

Initialise checks_multi_account as empty dict to add it filled or not when adding the allowlisted checks from all the AWS accounts

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jfagoagas
jfagoagas previously approved these changes Jul 14, 2023
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@n4ch04 n4ch04 merged commit 8f015d0 into master Jul 14, 2023
4 checks passed
@n4ch04 n4ch04 deleted the fix-allowlist-single-account-case branch July 14, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unbound local variable checks_multi_account
3 participants