fix(s3): __get_object_lock_configuration__ warning logs
#2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergargar
reviewed
Jul 24, 2023
Comment on lines
+299
to
+306
| if regional_client: | ||
| logger.warning( | ||
| f"{regional_client.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" | ||
| ) | ||
| else: | ||
| logger.warning( | ||
| f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" | ||
| ) |
There was a problem hiding this comment.
You can avoid repeating this lines by doing it outside the if.
There was a problem hiding this comment.
Yes but we want to raise error logs if a different exception is raised. The ones handled are set with warning.
sergargar
deleted the
PRWLR-2429-prowler-handle-o-such-bucket-291-an-error-occurred-no-such-bucket-when-calling-the-get-object-lock-configuration-operation-the-specified-bucket-does-not-exist
branch
sergargar
changed the title
__get_object_lock_configuration__ warning logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
errorlogs forwarningin the__get_object_lock_configuration__if theNoSuchBucketexception is raised.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.