feat(s3): Add checks for publicly listable Buckets or writable buckets by ACL #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
added
status/waiting-for-revision
|
Hi @jchrisfarris, thanks a lot for your contribution! We'll review it and let you know if everything is working fine. We'll include the missing tests but if you can give it a try we can guide you through it. Thanks for using Prowler 🚀 |
jfagoagas
changed the title
|
I've included tests and some fixes in the S3 check's metadata. |
jfagoagas
removed
status/waiting-for-revision
jfagoagas
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Thanks for your contribution @jchrisfarris, these new checks were necessary to have it in Prowler!
🚀 🚀 🚀 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While public buckets and bad, buckets that are either publicly writable or where anyone can list the objects are higher risk. This PR introduces two new checks specific to bucket ACLs that alert on these two use-cases:
s3_bucket_public_list_acls3_bucket_public_write_aclDescription
No dependencies. I did not see an open issue related to his.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.