Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudtrail): Set status to INFO when trail is outside the audited account #2643

Merged

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Jul 31, 2023

Description

Testing #2438 I realized that we are raising PASS or FAIL when the bucket trail is a cross-account bucket in another account out of Prowler's permissions scope, so we cannot check anything against it.

Due to the fact that we state please check it manually in the status_extended, I think we need to raise an INFO finding.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Jul 31, 2023
@jfagoagas jfagoagas requested a review from a team as a code owner July 31, 2023 15:11
@jfagoagas jfagoagas self-assigned this Jul 31, 2023
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jfagoagas jfagoagas merged commit 7bdca04 into master Jul 31, 2023
4 checks passed
@jfagoagas jfagoagas deleted the PRWLR-2199-bug-problem-with-aws-organizations-cloudtrail branch July 31, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants