fix(s3_bucket_level_public_access_block): check s3 public access block at account level #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
previously approved these changes
Aug 1, 2023
jfagoagas
requested changes
Aug 1, 2023
| @@ -5,6 +5,7 @@ | |||
| from moto import mock_s3, mock_s3control | |||
|
|
|||
| from prowler.providers.aws.lib.audit_info.models import AWS_Audit_Info | |||
| from prowler.providers.aws.services.s3.s3_service import S3Control | |||
There was a problem hiding this comment.
Please import this within each test, like S3
jfagoagas
approved these changes
Aug 1, 2023
sergargar
deleted the
2647-bug-s3_bucket_level_public_access_block-fails-even-though-public-access-is-blocked-at-the-account-level
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mark as Pass if s3 public access block is configured at account level in
s3_bucket_level_public_access_block.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.