fix(sns): allow default SNS policy with SourceOwner #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
requested changes
Aug 10, 2023
christiandavilakoobin
force-pushed
the
master
branch
from
00299e4
to
17a7f2e
Compare
christiandavilakoobin
force-pushed
the
master
branch
from
1e72232
to
2f59fef
Compare
|
Done! I don't find how to run the tests localy before the PR. I checked the CONTRIB docs, but it only says how to create or modify the tests, but not how to run them. |
You have to do a |
jfagoagas
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Thanks again @christiandavilakoobin !
I've fixed some tests, so this will be merged once the CI pass.
sergargar
added a commit
that referenced
this pull request
Aug 10, 2023
Co-authored-by: Azure Pipeplines CI <monitor@koobin.com> Co-authored-by: Sergio Garcia <sergargar1@gmail.com> Co-authored-by: Pepe Fagoaga <pepe@verica.io>
sergargar
added a commit
that referenced
this pull request
Aug 10, 2023
Co-authored-by: Azure Pipeplines CI <monitor@koobin.com> Co-authored-by: Sergio Garcia <sergargar1@gmail.com> Co-authored-by: Pepe Fagoaga <pepe@verica.io>
sergargar
added a commit
that referenced
this pull request
Aug 10, 2023
Co-authored-by: Azure Pipeplines CI <monitor@koobin.com> Co-authored-by: Sergio Garcia <sergargar1@gmail.com> Co-authored-by: Pepe Fagoaga <pepe@verica.io>
sergargar
added a commit
that referenced
this pull request
Aug 10, 2023
Co-authored-by: Azure Pipeplines CI <monitor@koobin.com> Co-authored-by: Sergio Garcia <sergargar1@gmail.com> Co-authored-by: Pepe Fagoaga <pepe@verica.io>
jfagoagas
added a commit
that referenced
this pull request
Aug 14, 2023
Co-authored-by: Azure Pipeplines CI <monitor@koobin.com> Co-authored-by: Sergio Garcia <sergargar1@gmail.com> Co-authored-by: Pepe Fagoaga <pepe@verica.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Prowler alerts for sns public accessibilty checks on topics that are generated from the AWS console.
Description
The AWS console uses the not very well documented AWS:SourceOwner attribute on defaults policies: awsdocs/iam-user-guide#111
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.