Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(s3): Mock S3Control when used #2722

Merged
merged 1 commit into from
Aug 14, 2023
Merged

test(s3): Mock S3Control when used #2722

merged 1 commit into from
Aug 14, 2023

Conversation

jfagoagas
Copy link
Member

Description

Mock S3Control when used.

I've removed the s3_client from the s3_account_level_public_access_blocks since it is no longer needed.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Aug 14, 2023
@jfagoagas jfagoagas self-assigned this Aug 14, 2023
@jfagoagas jfagoagas requested a review from a team as a code owner August 14, 2023 07:51
Copy link
Member

@toniblyx toniblyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfagoagas jfagoagas merged commit fc53b28 into master Aug 14, 2023
4 checks passed
@jfagoagas jfagoagas deleted the review-s3-tests branch August 14, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants