fix(get_checks_from_input_arn): fix logic and add tests #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2764 +/- ##
==========================================
+ Coverage 86.13% 86.25% +0.11%
==========================================
Files 528 531 +3
Lines 17098 17217 +119
==========================================
+ Hits 14728 14850 +122
+ Misses 2370 2367 -3
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
get_checks_from_input_arnfunction was not fully covered by tests and was not working properly, since it did not add checks if there were not include the subservice of the resource arnDescription
Add tests for all the services and sub-services included in the logic and fix the general case
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.