fix(ebs): improve snapshot encryption logic and typos #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2836 +/- ##
==========================================
- Coverage 86.25% 86.24% -0.01%
==========================================
Files 539 539
Lines 17312 17301 -11
==========================================
- Hits 14933 14922 -11
Misses 2379 2379
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sergargar
reviewed
Sep 13, 2023
sergargar
changed the title
|
@taylerhaviland I have made a change in the code because we need to check if the key Encrypted exists. Let me know if it still works on your side. |
|
Hi @sergargar, your change gives me the expected results. LGTM |
sergargar
approved these changes
Sep 15, 2023
jit-contrib
pushed a commit
to jit-contrib/prowler
that referenced
this pull request
Sep 28, 2023
…2836) Co-authored-by: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently the EC2 EBS snapshot encryption check results in false negatives.
Additionally, I have fixed two typos. One includes more accurately describing the function
__get_snapshot_public__Description
This PR fixes the logic to accurately FAIL unencrypted EBS snapshots. It also more accurately describes the
__get_snapshot_public__logging statement.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.