fix(securityhub): archive SecurityHub findings in empty regions #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
previously approved these changes
Oct 5, 2023
sergargar
force-pushed
the
archive-shub-regions
branch
from
7cdb5c8
to
5ad86fe
Compare
Codecov Report
@@ Coverage Diff @@
## master #2908 +/- ##
==========================================
- Coverage 86.24% 86.22% -0.03%
==========================================
Files 540 540
Lines 17496 17498 +2
==========================================
- Hits 15089 15087 -2
- Misses 2407 2411 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jfagoagas
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding #2190, when a region has no findings archive all the older findings in Security Hub in that region.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.