feat(compliance): execute all compliance by default #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergargar
force-pushed
the
execute-all-compliance-by-default
branch
from
b7fd698
to
cdf98ee
Compare
jfagoagas
requested changes
Dec 12, 2023
prowler/lib/outputs/compliance.py
Outdated
Comment on lines
63
to
77
| compliance_name = "" | ||
| if compliance.Version: | ||
| compliance_name = ( | ||
| compliance.Framework.lower() | ||
| + "_" | ||
| + compliance.Version.lower() | ||
| + "_" | ||
| + compliance.Provider.lower() | ||
| ) | ||
| else: | ||
| compliance_name = ( | ||
| compliance.Framework.lower() + "_" + compliance.Provider.lower() | ||
| ) | ||
| if compliance_name.replace("-", "_") in input_compliance_frameworks: | ||
| check_compliances.append(compliance) |
There was a problem hiding this comment.
Can you move this to a separate function to handle compliance framework names?
prowler/lib/outputs/compliance.py
Outdated
There was a problem hiding this comment.
Can you move each compliance output generator to a separate function? It'll help us to split code, do better tests and improve readability. Thanks!
For the following functions:
fill_compliancedisplay_compliance_table
There was a problem hiding this comment.
The same here, create a function to generate the file descriptor for each compliance mode not to have the same over and over.
…r-cloud/prowler into execute-all-compliance-by-default
sergargar
added a commit
that referenced
this pull request
Jan 16, 2024
Co-authored-by: Pepe Fagoaga <pepe@verica.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without
--compliance, prowler will execute all compliance frameworks by default.All compliance reports will be in output/compliance directory.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.