Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(audit_info): refactor kms #3157

Merged
merged 1 commit into from Dec 5, 2023
Merged

test(audit_info): refactor kms #3157

merged 1 commit into from Dec 5, 2023

Conversation

n4ch04
Copy link
Contributor

@n4ch04 n4ch04 commented Dec 5, 2023

Description

Refactor KMS to use the set_mocked_aws_audit_info helper.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@n4ch04 n4ch04 requested a review from a team as a code owner December 5, 2023 12:53
@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbc2c48) 86.30% compared to head (ba2af52) 86.29%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
- Coverage   86.30%   86.29%   -0.02%     
==========================================
  Files         562      562              
  Lines       18266    18266              
==========================================
- Hits        15764    15762       -2     
- Misses       2502     2504       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jfagoagas jfagoagas merged commit 250f59c into master Dec 5, 2023
7 of 8 checks passed
@jfagoagas jfagoagas deleted the refactor-audit-info-kms branch December 5, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants