Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add 13 checks of Kubernetes Core service #3315

Merged
merged 27 commits into from Feb 28, 2024
Merged

feat(core): add 13 checks of Kubernetes Core service #3315

merged 27 commits into from Feb 28, 2024

Conversation

sergargar
Copy link
Member

Description

Add 13 checks of Kubernetes Core service:

[core_minimize_admission_hostport_containers] Minimize the admission of containers which use HostPorts - Core [high]
[core_minimize_admission_windows_hostprocess_containers] Minimize the admission of Windows HostProcess Containers - Core [high]
[core_minimize_allowPrivilegeEscalation_containers] Minimize the admission of containers with allowPrivilegeEscalation - Core [high]
[core_minimize_containers_added_capabilities] Minimize the admission of containers with added capabilities - Core [high]
[core_minimize_containers_capabilities_assigned] Minimize the admission of containers with capabilities assigned - Core [high]
[core_minimize_hostIPC_containers] Minimize the admission of containers wishing to share the host IPC namespace - Core [high]
[core_minimize_hostNetwork_containers] Minimize the admission of containers wishing to share the host network namespace - Core [high]
[core_minimize_hostPID_containers] Minimize the admission of containers wishing to share the host process ID namespace - Core [high]
[core_minimize_net_raw_capability_admission] Minimize the admission of containers with the NET_RAW capability - Core [high]
[core_minimize_privileged_containers] Minimize the admission of privileged containers - Core [high]
[core_minimize_root_containers_admission] Minimize the admission of root containers - Core [high]
[core_no_secrets_envs] Prefer using secrets as files over secrets as environment variables - Core [medium]
[core_seccomp_profile_docker_default] Ensure that the seccomp profile is set to docker/default in your pod definitions - Core [high]

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested a review from a team as a code owner January 23, 2024 15:53
@sergargar sergargar added prowler-4.0 provider/kubernetes Issues/PRs related with the Kubernetes provider labels Jan 23, 2024
jfagoagas
jfagoagas requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @sergargar !!

Please review all the checks here https://docs.bridgecrew.io/docs/kubernetes-policy-index to add it to the metadata files in the IaC section.

...ion_windows_hostprocess_containers/core_minimize_admission_windows_hostprocess_containers.py Show resolved Hide resolved
...mize_admission_hostport_containers/core_minimize_admission_hostport_containers.metadata.json Outdated Show resolved Hide resolved
..._hostprocess_containers/core_minimize_admission_windows_hostprocess_containers.metadata.json Outdated Show resolved Hide resolved
...ivilegeEscalation_containers/core_minimize_allowPrivilegeEscalation_containers.metadata.json Outdated Show resolved Hide resolved
...mize_containers_added_capabilities/core_minimize_containers_added_capabilities.metadata.json Outdated Show resolved Hide resolved
...nimize_net_raw_capability_admission/core_minimize_net_raw_capability_admission.metadata.json Outdated Show resolved Hide resolved
...s/core/core_minimize_privileged_containers/core_minimize_privileged_containers.metadata.json Outdated Show resolved Hide resolved
...ore_minimize_root_containers_admission/core_minimize_root_containers_admission.metadata.json Outdated Show resolved Hide resolved
...r/providers/kubernetes/services/core/core_no_secrets_envs/core_no_secrets_envs.metadata.json Outdated Show resolved Hide resolved
...s/core/core_seccomp_profile_docker_default/core_seccomp_profile_docker_default.metadata.json Outdated Show resolved Hide resolved
@jfagoagas jfagoagas self-requested a review February 28, 2024 09:59
jfagoagas
jfagoagas requested changes Feb 28, 2024
View reviewed changes
...ion_windows_hostprocess_containers/core_minimize_admission_windows_hostprocess_containers.py Outdated Show resolved Hide resolved
...ion_windows_hostprocess_containers/core_minimize_admission_windows_hostprocess_containers.py Outdated Show resolved Hide resolved
...ivilegeEscalation_containers/core_minimize_allowPrivilegeEscalation_containers.metadata.json Outdated Show resolved Hide resolved
...ize_allowPrivilegeEscalation_containers/core_minimize_allowPrivilegeEscalation_containers.py Outdated Show resolved Hide resolved
..._minimize_containers_capabilities_assigned/core_minimize_containers_capabilities_assigned.py Show resolved Hide resolved
...ore/core_minimize_net_raw_capability_admission/core_minimize_net_raw_capability_admission.py Outdated Show resolved Hide resolved
prowler/providers/kubernetes/services/core/core_service.py Outdated Show resolved Hide resolved
@sergargar @jfagoagas
Apply suggestions from code review
ff95017 
Co-authored-by: Pepe Fagoaga <pepe@prowler.com>
jfagoagas
jfagoagas approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one ready to be merged!!

Thanks for the effort @sergargar 🏅

@jfagoagas jfagoagas merged commit 3c4e5a1 into prowler-4.0-dev Feb 28, 2024
3 of 7 checks passed
@jfagoagas jfagoagas deleted the core-checks branch February 28, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfagoagas jfagoagas jfagoagas approved these changes

Assignees
No one assigned
Labels
provider/kubernetes Issues/PRs related with the Kubernetes provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sergargar @jfagoagas