fix(organizations): Handle non existent policy #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3319 +/- ##
==========================================
+ Coverage 85.87% 85.90% +0.02%
==========================================
Files 564 565 +1
Lines 18257 18292 +35
==========================================
+ Hits 15679 15714 +35
Misses 2578 2578 ☔ View full report in Codecov by Sentry. |
sergargar
reviewed
Jan 29, 2024
| except Exception as error: | ||
| logger.error( | ||
| f"{self.region} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" | ||
| ) | ||
| finally: | ||
| return policy_content_json | ||
| return json.loads(policy_content) | ||
|
|
||
| def __list_targets_for_policy__(self, policy_id): |
There was a problem hiding this comment.
You have to check in this function if policy_id is not None too.
sergargar
deleted the
unbound-local-error-105-cannot-access-local-variable-policy-content
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle JSON policy returned by
describe_policywhen an exception is caught.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.