feat(azure): Add check defender_auto_provisioning_log_analytics_agent_vms_on
#3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it ensure that Auto Provisioning Log Analytics Agents in VMs is on
…orking in different situations
jfagoagas
requested changes
Jan 26, 2024
...g_analytics_agent_vms_on/defender_auto_provisioning_log_analytics_agent_vms_on.metadata.json
Outdated
Show resolved
Hide resolved
| "CLI": "https://www.trendmicro.com/cloudoneconformity-staging/knowledge-base/azure/SecurityCenter/automatic-provisioning-of-monitoring-agent.html", | ||
| "NativeIaC": "", | ||
| "Other": "", | ||
| "Terraform": "https://docs.bridgecrew.io/docs/ensure-that-azure-defender-is-set-to-on-for-app-service#terraform" |
...g_analytics_agent_vms_on/defender_auto_provisioning_log_analytics_agent_vms_on.metadata.json
Outdated
Show resolved
Hide resolved
Comment on lines
60
to
62
| logger.error(f"Subscription name: {subscription}") | ||
| logger.error( | ||
| f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" |
There was a problem hiding this comment.
Suggested change
| logger.error(f"Subscription name: {subscription}") | |
| logger.error( | |
| f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" | |
| logger.error( | |
| f"Subscription name: {subscription} -- {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" |
| report = Check_Report_Azure(self.metadata()) | ||
| report.status = "PASS" | ||
| report.subscription = subscription | ||
| report.resource_name = "Defender Auto Provisioning Log Analytics Agents On" |
There was a problem hiding this comment.
The resource_name maybe should be the auto_provisioning_settings.name, what do you think?
...isioning_log_analytics_agent_vms_on/defender_auto_provisioning_log_analytics_agent_vms_on.py
Outdated
Show resolved
Hide resolved
...isioning_log_analytics_agent_vms_on/defender_auto_provisioning_log_analytics_agent_vms_on.py
Outdated
Show resolved
Hide resolved
...isioning_log_analytics_agent_vms_on/defender_auto_provisioning_log_analytics_agent_vms_on.py
Outdated
Show resolved
Hide resolved
|
|
||
| from prowler.providers.azure.services.defender.defender_service import AutoProvisioningSetting | ||
|
|
||
| AZURE_SUSCRIPTION = str(uuid4()) |
There was a problem hiding this comment.
You can use this value from the tests/prowler/providers/azure/azure_fixtures.py. Pedro included that in the previous PR.
…ioning_log_analytics_agent_vms_on/defender_auto_provisioning_log_analytics_agent_vms_on.metadata.json Co-authored-by: Pepe Fagoaga <pepe@verica.io>
…ioning_log_analytics_agent_vms_on/defender_auto_provisioning_log_analytics_agent_vms_on.metadata.json Co-authored-by: Pepe Fagoaga <pepe@verica.io>
…ioning_log_analytics_agent_vms_on/defender_auto_provisioning_log_analytics_agent_vms_on.py Co-authored-by: Pepe Fagoaga <pepe@verica.io>
…ioning_log_analytics_agent_vms_on/defender_auto_provisioning_log_analytics_agent_vms_on.py Co-authored-by: Pepe Fagoaga <pepe@verica.io>
…-microsoft-defender
…prowler into azure-checks-microsoft-defender
jfagoagas
changed the title
…ProvisioningSetting
jfagoagas
previously requested changes
Jan 26, 2024
There was a problem hiding this comment.
I'm still not sure if we should include a condition in the check just to only audit the default resource because some clients can have different or custom things in Azure and in that case we will generate findings maybe not having to. My vote is to include that filter for now to be 100% sure.
Also this check is going to be deprecated in August 2024 per https://learn.microsoft.com/en-us/azure/azure-monitor/agents/log-analytics-agent
Let's talk with @sergargar on Monday.
| report = Check_Report_Azure(self.metadata()) | ||
| report.status = "PASS" | ||
| report.subscription = subscription_name | ||
| report.resource_name = auto_provisioning_settings["default"].resource_name |
There was a problem hiding this comment.
I'm still not sure if we should include here a condition just to review the default resource. Let's talk with @sergargar on Monday.
…t works with multiple workspaces
sergargar
reviewed
Jan 29, 2024
| "RelatedUrl": "https://www.trendmicro.com/cloudoneconformity-staging/knowledge-base/azure/SecurityCenter/automatic-provisioning-of-monitoring-agent.html", | ||
| "Remediation": { | ||
| "Code": { | ||
| "CLI": "https://www.trendmicro.com/cloudoneconformity-staging/knowledge-base/azure/SecurityCenter/automatic-provisioning-of-monitoring-agent.html", |
There was a problem hiding this comment.
Put this link in "Other", please
sergargar
changed the title
defender_auto_provisioning_log_analytics_agent_vms_on
sergargar
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add new check to ensure Auto Provisioning Log Analytics in VMs is On
Description
Add the new check for Defender service with its respective unit tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.