feat(azure): New check storage_ensure_soft_delete_is_enabled
#3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrooot
changed the title
storage_ensure_soft_delete_is_enabled
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3334 +/- ##
==========================================
- Coverage 85.91% 85.87% -0.04%
==========================================
Files 568 571 +3
Lines 18345 18441 +96
==========================================
+ Hits 15761 15837 +76
- Misses 2584 2604 +20 ☔ View full report in Codecov by Sentry. |
sergargar
reviewed
Jan 30, 2024
| report.resource_name = storage_account.name | ||
| report.resource_id = storage_account.id | ||
| if ( | ||
| storage_account.blob_properties.container_delete_retention_policy.enabled |
There was a problem hiding this comment.
What happens if storage_account.blob_properties is None?
There was a problem hiding this comment.
True! I modify it to handle correctly.
Thanks for the review
sergargar
reviewed
Jan 30, 2024
| @@ -42,11 +53,42 @@ def __get_storage_accounts__(self): | |||
| ) | |||
| return storage_accounts | |||
|
|
|||
| def __get_blob_properties__(self): | |||
There was a problem hiding this comment.
Can you add the test of this function in storage_service_test.py, pleae?
sergargar
requested changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pr contains a the new Azure check
storage_ensure_soft_delete_is_enabledDescription
This check makes this task:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.