Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backup): handle if last_attempted_execution_date is None #3394

Merged
merged 1 commit into from Feb 13, 2024

Conversation

sergargar
Copy link
Member

Description

Make last_attempted_execution_date attribute as Optional in Backup Report Plan to handle if last_attempted_execution_date is None.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested a review from a team as a code owner February 13, 2024 08:53
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one!

@sergargar sergargar added the provider/aws Issues/PRs related with the AWS provider label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (042976f) 85.85% compared to head (7a327c5) 85.85%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3394   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files         586      586           
  Lines       18893    18893           
=======================================
  Hits        16220    16220           
  Misses       2673     2673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 9f16e4d into master Feb 13, 2024
9 checks passed
@sergargar sergargar deleted the fix-backup-error branch February 13, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants