Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): check related with App Insights service #3395

Merged
merged 7 commits into from Feb 13, 2024

Conversation

puchy22
Copy link
Contributor

@puchy22 puchy22 commented Feb 13, 2024

Context

Add new check for Azure that are related with App Insights to ensure that at leat exists one in the subscription

Description

I create the new appinsight service and related check appinsights_ensure_is_configured with the unit testing for everything

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested a review from a team as a code owner February 13, 2024 10:40
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!!

@sergargar sergargar added the provider/azure Issues/PRs related with the Azure provider label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (cc71249) 85.85% compared to head (471d676) 85.84%.

Files Patch % Lines
.../azure/services/appinsights/appinsights_service.py 72.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3395      +/-   ##
==========================================
- Coverage   85.85%   85.84%   -0.01%     
==========================================
  Files         586      589       +3     
  Lines       18893    18938      +45     
==========================================
+ Hits        16220    16258      +38     
- Misses       2673     2680       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 4740a7b into prowler-cloud:master Feb 13, 2024
7 of 9 checks passed
@puchy22 puchy22 deleted the azure-app-insights branch March 25, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants