Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(namespace): add --namespaces argument and solve bugs #3431

Merged
merged 31 commits into from
Feb 28, 2024
Merged

feat(namespace): add --namespaces argument and solve bugs #3431

merged 31 commits into from
Feb 28, 2024

Conversation

sergargar
Copy link
Member

@sergargar sergargar commented Feb 22, 2024 •
edited
Loading

Description

Add --namespaces argument to allow scanning one or more specific namespaces and solve the following bugs:

  1. Extracted credentials and prints from the first context of the configuration.
  2. Implemented the functionality to extract the correct context.
  3. Implemented a timeout verification mechanism.
  4. Resolved the issue of erroneous namespaces in credentials.
  5. Addressed the duplication of services in the summary table.
  6. Updated filename handling to support special characters such as ":" and "/" from the ARN.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sergargar and others added 22 commits January 9, 2024 12:41
@sergargar
add etcd and controllermanager services
5a40b07
@sergargar
add rbac service
cc76a42
@sergargar
add apiserver checks
3632aaf
@sergargar
add apiserver checks part 2
8294284
@sergargar
add apiserver checks part 3
86e12bf
@sergargar
change check names
2b5d78e
@sergargar
improve checks logic
7bb9c5e
@sergargar
improve checks logic
f743551
@sergargar
Merge branch 'prowler-4.0-dev' into k8s-services
718ca84
@sergargar
feat(controllermanager): add checks for Kubernetes Controller Manager
ed394ca
@sergargar
feat(etcd): add checks for Kubernetes etcd
0ce5cdc
@sergargar
feat(kubelet): add 10 checks of Kubernetes Kubelet service
30c10d3
@sergargar
feat(kubelet): add 9 checks of Kubernetes RBAC service
6db4d3a
@sergargar
feat(core): add 11 checks of Kubernetes Core service
7f79a93
@sergargar
add 2 more checks
845e9b2
@sergargar
fix core service names
faabdf0
@sergargar
feat(kubelet): add 6 checks of Kubelet configuration files on the wor…
3286350 
…ker nodes
@sergargar
fix(kubernetes): improve in-cluster execution
357c81a
@sergargar
feat(namespace): add --namespace argument and solve bugs
6468ee6
@sergargar
list pods for the specific namespace
3d801e7
@sergargar
allow multiple namespaces
b92d9f4
@sergargar
sanitize output file name
607695e
@sergargar sergargar requested a review from a team as a code owner February 22, 2024 15:36
@jfagoagas jfagoagas added prowler-4.0 provider/kubernetes Issues/PRs related with the Kubernetes provider labels Feb 22, 2024
jfagoagas
jfagoagas reviewed Feb 28, 2024
View reviewed changes
prowler/providers/kubernetes/kubernetes_provider_new.py Outdated
@@ -14,32 +14,59 @@ class KubernetesProvider(Provider):
# TODO change class name from Provider to Provider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TODO change class name from Provider to Provider
# TODO change class name from Provider to Provider

jfagoagas
jfagoagas approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergargar sergargar merged commit b0f2f34 into prowler-4.0-dev Feb 28, 2024
3 of 7 checks passed
@sergargar sergargar deleted the kubernetes-provider branch February 28, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfagoagas jfagoagas jfagoagas approved these changes

Assignees
No one assigned
Labels
provider/kubernetes Issues/PRs related with the Kubernetes provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sergargar @jfagoagas