fix(gcp): handle KeyError in Compute service #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/gcp
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3471 +/- ##
==========================================
+ Coverage 85.81% 85.85% +0.03%
==========================================
Files 660 660
Lines 20578 20578
==========================================
+ Hits 17660 17668 +8
+ Misses 2918 2910 -8 ☔ View full report in Codecov by Sentry. |
sergargar
deleted the
3426-bug-not-getting-results-for-gcp-compute-instances-with-public-ips
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle KeyErrors in Compute service so all the Instances can be retrieved.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.