Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gcp): add Shodan check for GCP External Addresses #3486

Merged
merged 3 commits into from Mar 14, 2024

Conversation

sergargar
Copy link
Member

Description

Add Shodan check for GCP External Addresses called compute_public_address_shodan

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested a review from a team as a code owner March 4, 2024 13:46
Copy link
Contributor

github-actions bot commented Mar 4, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions github-actions bot added documentation provider/gcp Issues/PRs related with the Google Cloud Platform provider labels Mar 4, 2024
@jfagoagas jfagoagas added the backport-v3 Pending to port to Prowler v3 branch label Mar 6, 2024
"SubServiceName": "",
"ResourceIdTemplate": "",
"Severity": "high",
"ResourceType": "AwsEc2Eip",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review please.

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

jfagoagas
jfagoagas previously approved these changes Mar 14, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 67.27273% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 85.91%. Comparing base (98dea32) to head (f100b6f).
Report is 30 commits behind head on master.

Files Patch % Lines
.../providers/gcp/services/compute/compute_service.py 50.00% 10 Missing ⚠️
...ic_address_shodan/compute_public_address_shodan.py 73.33% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3486      +/-   ##
==========================================
+ Coverage   85.87%   85.91%   +0.04%     
==========================================
  Files         662      676      +14     
  Lines       20643    20979     +336     
==========================================
+ Hits        17727    18025     +298     
- Misses       2916     2954      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 41373ca into master Mar 14, 2024
11 of 12 checks passed
@sergargar sergargar deleted the gcp-shodan-check branch March 14, 2024 13:57
@sergargar sergargar removed the backport-v3 Pending to port to Prowler v3 branch label Mar 15, 2024
sergargar added a commit that referenced this pull request Mar 15, 2024
Co-authored-by: Pepe Fagoaga <pepe@prowler.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation provider/gcp Issues/PRs related with the Google Cloud Platform provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants