Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compliance): set the provider dynamically in Manual checks #3502

Merged
merged 2 commits into from Mar 5, 2024

Conversation

sergargar
Copy link
Member

@sergargar sergargar commented Mar 5, 2024

Description

Set the provider dynamically in Manual checks since it was set AWS by default.
Thanks @pedrooot for the catch!

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested a review from a team as a code owner March 5, 2024 12:49
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.83%. Comparing base (3eeca73) to head (3ac13e5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3502   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files         662      662           
  Lines       20643    20643           
=======================================
  Hits        17719    17719           
  Misses       2924     2924           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 00ab5b5 into master Mar 5, 2024
11 checks passed
@sergargar sergargar deleted the fix-manual-check branch March 5, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants