feat(Azure): Entra service with two checks #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_cannot_create_tenants`
…er_cannot_create_apps`
github-actions
bot
added
the
provider/azure
puchy22
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3510 +/- ##
==========================================
+ Coverage 85.89% 85.98% +0.08%
==========================================
Files 670 674 +4
Lines 20826 20894 +68
==========================================
+ Hits 17889 17965 +76
+ Misses 2937 2929 -8 ☔ View full report in Codecov by Sentry. |
jfagoagas
previously approved these changes
Mar 8, 2024
| report.subscription = "All" | ||
| report.resource_name = "Default Authorization Policy" | ||
| report.resource_id = "Default Authorization Policy" | ||
| report.status_extended = "Tenants creation is not disabled for non-admin users." |
There was a problem hiding this comment.
Check this status extended please.
| ) | ||
| except Exception as error: | ||
| logger.error( | ||
| f"ERROR: {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" |
There was a problem hiding this comment.
Suggested change
| f"ERROR: {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" | |
| f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" |
| ) | ||
| except Exception as error: | ||
| logger.error( | ||
| f"ERROR: {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" |
There was a problem hiding this comment.
Suggested change
| f"ERROR: {error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" | |
| f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add new Microsoft Entra service and checks for Azure. The core code of the service was provided by my partner @pedrooot 🚀
Description
Add this checks with his respective unit tests:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.