feat(azure): 10 new checks related with alerts in monitoring #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/azure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3516 +/- ##
==========================================
+ Coverage 85.88% 86.08% +0.19%
==========================================
Files 662 687 +25
Lines 20621 21234 +613
==========================================
+ Hits 17711 18279 +568
- Misses 2910 2955 +45 ☔ View full report in Codecov by Sentry. |
sergargar
reviewed
Mar 13, 2024
...rs/azure/services/monitor/monitor_alert_create_update_nsg/monitor_alert_create_update_nsg.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Mar 13, 2024
...er/providers/azure/services/monitor/lib/monitoring_alerts_review/monitoring_alerts_review.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Mar 14, 2024
...ces/monitor/monitor_alert_create_policy_assignment/monitor_alert_create_policy_assignment.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Mar 14, 2024
...er/providers/azure/services/monitor/lib/monitoring_alerts_review/monitoring_alerts_review.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Mar 14, 2024
...er/providers/azure/services/monitor/lib/monitoring_alerts_review/monitoring_alerts_review.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
10 new checks related with alerts in monitoring.
Description
This checks ensure that alerts for creating/updating/deleting certain Azure components.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.