Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudwatch): correct recommendation text #3538

Conversation

sergargar
Copy link
Member

Description

The recommendation section of this check indicates the filter pattern should be as follows which is wrong since it is misisng the eventSource.

{($.eventSource = ec2.amazonaws.com) && (($.eventName = CreateRoute) || ($.eventName = CreateRouteTable) || ($.eventName = ReplaceRoute) || ($.eventName = ReplaceRouteTableAssociation) || ($.eventName = DeleteRouteTable) || ($.eventName = DeleteRoute) || ($.eventName = DisassociateRouteTable)) }

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested a review from a team as a code owner March 14, 2024 10:01
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Mar 14, 2024
@sergargar sergargar added the backport-v3 Pending to port to Prowler v3 branch label Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.98%. Comparing base (ed60958) to head (6c4c366).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3538      +/-   ##
==========================================
+ Coverage   85.95%   85.98%   +0.03%     
==========================================
  Files         674      674              
  Lines       20903    20903              
==========================================
+ Hits        17967    17974       +7     
+ Misses       2936     2929       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about removing the new lines?

Check the blame since we included that a while ago to fix a customer's bug, that regexp should handle new lines because the expression would be valid too.

@jfagoagas jfagoagas self-requested a review March 14, 2024 12:20
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous comment doesn't apply here.

Thanks @sergargar !!

@jfagoagas jfagoagas merged commit 65edaea into master Mar 14, 2024
11 checks passed
@jfagoagas jfagoagas deleted the 3536-bug-recommendation-is-incorrect-for-check-cloudwatch_changes_to_network_route_tables_alarm_configured branch March 14, 2024 12:20
@sergargar sergargar removed the backport-v3 Pending to port to Prowler v3 branch label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Recommendation is incorrect for check "cloudwatch_changes_to_network_route_tables_alarm_configured"
2 participants