Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(audit_info): Replace for provider and add tests #3542

Conversation

jfagoagas
Copy link
Member

Context

Please include relevant motivation and context for this PR.

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Mar 14, 2024
@github-actions github-actions bot added provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider labels Mar 18, 2024
@jfagoagas jfagoagas marked this pull request as ready for review March 18, 2024 16:56
@jfagoagas jfagoagas requested a review from a team as a code owner March 18, 2024 16:56
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 73.13433% with 18 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (prowler-4.0-dev@63cd6c1). Click here to learn what that means.

Files Patch % Lines
prowler/providers/common/provider.py 50.00% 13 Missing ⚠️
prowler/providers/aws/aws_provider.py 73.33% 4 Missing ⚠️
prowler/lib/outputs/outputs.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             prowler-4.0-dev    #3542   +/-   ##
==================================================
  Coverage                   ?   86.14%           
==================================================
  Files                      ?      684           
  Lines                      ?    21132           
  Branches                   ?        0           
==================================================
  Hits                       ?    18204           
  Misses                     ?     2928           
  Partials                   ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a job 👏🏼

@sergargar sergargar merged commit 77823af into prowler-4.0-dev Mar 19, 2024
11 checks passed
@sergargar sergargar deleted the PRWLR-3369-prowler-remove-gcp-azure-and-k-8-s-audit-info branch March 19, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants