Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure):App check related with http logs #3568

Merged
merged 4 commits into from Mar 20, 2024

Conversation

Hugo966
Copy link
Contributor

@Hugo966 Hugo966 commented Mar 19, 2024

Context

App service check related with HTTP Logs

Description

This check ensures HTTP Logs are enabled in app webs so that those web requests are captured.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hugo966 Hugo966 requested a review from a team as a code owner March 19, 2024 11:16
@github-actions github-actions bot added the provider/azure Issues/PRs related with the Azure provider label Mar 19, 2024
@sergargar sergargar added the backport-v3 Pending to port to Prowler v3 branch label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.02%. Comparing base (bfda613) to head (1ca1d1f).
Report is 9 commits behind head on master.

Files Patch % Lines
...rowler/providers/azure/services/app/app_service.py 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3568      +/-   ##
==========================================
- Coverage   86.03%   86.02%   -0.01%     
==========================================
  Files         689      690       +1     
  Lines       21307    21343      +36     
==========================================
+ Hits        18332    18361      +29     
- Misses       2975     2982       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@sergargar sergargar merged commit e224215 into prowler-cloud:master Mar 20, 2024
9 of 11 checks passed
@sergargar sergargar removed the backport-v3 Pending to port to Prowler v3 branch label Mar 21, 2024
sergargar added a commit that referenced this pull request Mar 21, 2024
Co-authored-by: Sergio Garcia <sergargar1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants