chore(muted): handle new Muted status #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## prowler-4.0-dev #3570 +/- ##
===================================================
- Coverage 86.21% 86.20% -0.01%
===================================================
Files 703 703
Lines 21633 21631 -2
===================================================
- Hits 18650 18648 -2
Misses 2983 2983 ☔ View full report in Codecov by Sentry. |
jfagoagas
requested changes
Mar 19, 2024
| @@ -11,16 +11,17 @@ | |||
| from prowler.lib.utils.utils import hash_sha512 | |||
|
|
|||
|
|
|||
| def generate_json_asff_status(status: str) -> str: | |||
| def generate_json_asff_status(status: str, muted: bool = False) -> str: | |||
There was a problem hiding this comment.
Where are you calling this function with the new muted field?
Please add a test to check the new behaviour?
There was a problem hiding this comment.
I added where it is needed, good catch. There is already a test for this.
jfagoagas
previously approved these changes
Mar 19, 2024
jfagoagas
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle new Muted status in check with
mute_non_default_regionsvariable.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.