fix(cloudtrail): use dictionary instead of list #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3579 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 690 690
Lines 21343 21343
=======================================
Hits 18369 18369
Misses 2974 2974 ☔ View full report in Codecov by Sentry. |
jfagoagas
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Great catch and improvement @sergargar !!
Always raising the bar 👏
| @@ -7,7 +7,8 @@ | |||
| class cloudtrail_insights_exist(Check): | |||
| def execute(self): | |||
| findings = [] | |||
| for trail in cloudtrail_client.trails: | |||
| for trail in cloudtrail_client.trails.values(): | |||
| print(trail.arn) | |||
There was a problem hiding this comment.
Suggested change
| print(trail.arn) |
| @@ -45,27 +45,23 @@ def __get_trails__(self, regional_client): | |||
| kms_key_id = trail["KmsKeyId"] | |||
| if "CloudWatchLogsLogGroupArn" in trail: | |||
| log_group_arn = trail["CloudWatchLogsLogGroupArn"] | |||
There was a problem hiding this comment.
please, get the trail["TrailARN"] first and the use it in the code.
jfagoagas
pushed a commit
that referenced
this pull request
Mar 21, 2024
sergargar
added a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order for not having duplicate Trails in memory, use a dictionary to store unique trails based on the ARN.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.