chore(gcp): remove unnecessary default project id #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/gcp
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3586 +/- ##
==========================================
- Coverage 86.03% 86.02% -0.01%
==========================================
Files 690 690
Lines 21342 21340 -2
==========================================
- Hits 18361 18358 -3
- Misses 2981 2982 +1 ☔ View full report in Codecov by Sentry. |
jfagoagas
requested changes
Mar 21, 2024
| self.credentials, self.default_project_id = self.__set_credentials__( | ||
| credentials_file | ||
| ) | ||
| self.credentials, _ = self.__set_credentials__(credentials_file) |
There was a problem hiding this comment.
I think it'll be better to catch the return from the __set_credentials__ within that function and just return the credentials object.
|
No backport needed since this is done in this PR #3587 |
jfagoagas
pushed a commit
that referenced
this pull request
Mar 22, 2024
pedrooot
pushed a commit
to pedrooot/prowler
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessary GCP default project id.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.