Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): locations added to Azure findings #3596

Merged
merged 7 commits into from Mar 22, 2024

Conversation

Hugo966
Copy link
Contributor

@Hugo966 Hugo966 commented Mar 22, 2024

Context

Add Azure locations to reports

Description

Now Azure locations are added to the reports generated the checks, this will be useful for users that now can see where the check that is failing is coming from.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hugo966 Hugo966 requested a review from a team as a code owner March 22, 2024 13:00
@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider github_actions Pull requests that update GitHub Actions code labels Mar 22, 2024
@Hugo966 Hugo966 changed the base branch from master to prowler-4.0-dev March 22, 2024 13:01
@sergargar sergargar changed the title Feat(azure): Locations added to findings feat(azure): locations added to Azure findings Mar 22, 2024
@sergargar sergargar self-requested a review March 22, 2024 13:11
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @Hugo966 !!

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 86.22%. Comparing base (245512d) to head (f225d53).

Files Patch % Lines
...rs/azure/services/postgresql/postgresql_service.py 33.33% 4 Missing ⚠️
...ders/azure/services/sqlserver/sqlserver_service.py 33.33% 4 Missing ⚠️
prowler/lib/outputs/common.py 0.00% 1 Missing ⚠️
...yvault_logging_enabled/keyvault_logging_enabled.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           prowler-4.0-dev    #3596      +/-   ##
===================================================
+ Coverage            86.17%   86.22%   +0.05%     
===================================================
  Files                  704      704              
  Lines                21688    21779      +91     
===================================================
+ Hits                 18690    18780      +90     
- Misses                2998     2999       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 1506da5 into prowler-cloud:prowler-4.0-dev Mar 22, 2024
11 checks passed
@jfagoagas jfagoagas removed documentation provider/aws Issues/PRs related with the AWS provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider github_actions Pull requests that update GitHub Actions code labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants