chore(action): Prepare containers release for v4 #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
added
no-merge
github-actions
bot
added
the
github_actions
jfagoagas
changed the title
n4ch04
reviewed
Apr 2, 2024
| PROWLER_VERSION_MAJOR="${PROWLER_VERSION%%.*}" | ||
| echo "PROWLER_VERSION_MAJOR=${PROWLER_VERSION_MAJOR}" >> "${GITHUB_ENV}" | ||
|
|
||
| case ${PROWLER_VERSION_MAJOR} in |
There was a problem hiding this comment.
This is returning the same in both case statements
There was a problem hiding this comment.
Or it is just a way to set the major for just the v3 and v4?
There was a problem hiding this comment.
It's just prepared for the v4 release, as you can see the commented code will be uncommented for the v4 release:
3)
# TODO: update it for v3 and v4
# echo "LATEST=v3-latest" >> "${GITHUB_ENV}"
# echo "STABLE_TAG=v3-stable" >> "${GITHUB_ENV}"
echo "LATEST=latest" >> "${GITHUB_ENV}"
echo "STABLE_TAG=stable" >> "${GITHUB_ENV}"
;;
# TODO: uncomment for v3 and v4
# 4)
# echo "LATEST=latest" >> "${GITHUB_ENV}"
# echo "STABLE_TAG=stable" >> "${GITHUB_ENV}"
# ;;
| if: github.event_name == 'push' | ||
|
|
||
| - name: Dispatch event (latest) | ||
| if: github.event_name == 'push' && ${{ env. PROWLER_VERSION_MAJOR }} == '3' |
There was a problem hiding this comment.
This is gonna be available only for version 3?
There was a problem hiding this comment.
At least for now, we haven't tested it with v4 yet.
n4ch04
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For the upcoming Prowler v4 we need to be able to handle different paths for both v3 and v4 while releasing packages or pushing latest changes.
Description
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.