Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sts): handle China STS regions #3613

Merged

Conversation

sergargar
Copy link
Member

Description

Correct the STS Endpoint URL when using Prowler in China partition.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar sergargar requested a review from a team as a code owner March 26, 2024 12:55
@sergargar sergargar linked an issue Mar 26, 2024 that may be closed by this pull request
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Mar 26, 2024
@sergargar sergargar added the backport-v3 Pending to port to Prowler v3 branch label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.10%. Comparing base (acbd2a8) to head (85a4e35).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
- Coverage   86.14%   86.10%   -0.04%     
==========================================
  Files         699      699              
  Lines       21574    21575       +1     
==========================================
- Hits        18585    18578       -7     
- Misses       2989     2997       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n4ch04 n4ch04 merged commit 3015381 into master Mar 27, 2024
10 of 11 checks passed
@n4ch04 n4ch04 deleted the 3612-bug-sts-endpoint-is-wrong-for-the-chinese-aws-regions branch March 27, 2024 10:18
sergargar added a commit that referenced this pull request Apr 1, 2024
@sergargar sergargar removed the backport-v3 Pending to port to Prowler v3 branch label Apr 1, 2024
pedrooot pushed a commit to pedrooot/prowler that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: STS endpoint is wrong for the Chinese AWS regions
2 participants