chore(slogan): update Prowler slogan #3619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## prowler-4.0-dev #3619 +/- ##
===================================================
- Coverage 86.09% 86.08% -0.01%
===================================================
Files 705 705
Lines 21862 21868 +6
===================================================
+ Hits 18822 18826 +4
- Misses 3040 3042 +2 ☔ View full report in Codecov by Sentry. |
jfagoagas
requested changes
Apr 1, 2024
tests/lib/outputs/slack_test.py
Outdated
| @@ -65,7 +65,7 @@ def test_create_message_blocks(self): | |||
| "type": "section", | |||
| "text": { | |||
| "type": "mrkdwn", | |||
| "text": f"Hey there 👋 \n I'm *Prowler*, _the handy cloud security tool_ :cloud::key:\n\n I have just finished the security assessment on your {aws_identity} with a total of *{stats['findings_count']}* findings.", | |||
| "text": f"Hey there 👋 \n I'm *Prowler*, _the handy multi-cloud security tool_ :cloud::key:\n\n I have just finished the security assessment on your {aws_identity} with a total of *{stats['findings_count']}* findings.", | |||
There was a problem hiding this comment.
Could you please move this text to a constant since it is always the same? Save it in the prowler/lib/outputs/slack.py and then use it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Prowler slogan.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.