Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure):Check related with roles and vm access with mfa #3638

Merged
merged 2 commits into from Apr 2, 2024

Conversation

Hugo966
Copy link
Contributor

@Hugo966 Hugo966 commented Apr 2, 2024

Context

Check related with vm access privileges and MFA

Description

If a user hasta roles that allows them to access and vm, they should have MFA activated

Check name changed from "entra_users_less_than_five_global_admins" to "entra_global_admin_in_less_than_five_users"

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hugo966 Hugo966 requested a review from a team as a code owner April 2, 2024 09:45
@github-actions github-actions bot added the provider/azure Issues/PRs related with the Azure provider label Apr 2, 2024
@sergargar sergargar added the backport-v3 Pending to port to Prowler v3 branch label Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 86.00%. Comparing base (6c7c36b) to head (dcde68a).
Report is 9 commits behind head on master.

Files Patch % Lines
...rowler/providers/azure/services/iam/iam_service.py 57.89% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3638      +/-   ##
==========================================
- Coverage   86.04%   86.00%   -0.04%     
==========================================
  Files         704      706       +2     
  Lines       21749    21798      +49     
==========================================
+ Hits        18713    18747      +34     
- Misses       3036     3051      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooo

@jfagoagas jfagoagas merged commit be19ec5 into prowler-cloud:master Apr 2, 2024
9 of 11 checks passed
@sergargar sergargar removed the backport-v3 Pending to port to Prowler v3 branch label Apr 3, 2024
sergargar added a commit that referenced this pull request Apr 3, 2024
Co-authored-by: Hugo Gálvez Ureña <hugogalvezu96@gmail.com>
Co-authored-by: Sergio <sergio@prowler.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants