Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): add DefaultValue to Azure CIS compliance #3652

Merged
merged 2 commits into from Apr 3, 2024
Merged

Conversation

pedrooot
Copy link
Contributor

@pedrooot pedrooot commented Apr 3, 2024

Context

This pr adds DefaultValue for CIS csv output for Azure

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested a review from a team as a code owner April 3, 2024 15:28
@jfagoagas jfagoagas added backport-v3 Pending to port to Prowler v3 branch and removed backport-v3 Pending to port to Prowler v3 branch labels Apr 3, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.02%. Comparing base (8b085c4) to head (cd80f5c).

Files Patch % Lines
prowler/lib/outputs/compliance.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3652      +/-   ##
==========================================
- Coverage   86.03%   86.02%   -0.01%     
==========================================
  Files         706      706              
  Lines       21835    21835              
==========================================
- Hits        18786    18784       -2     
- Misses       3049     3051       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar changed the title fix(CIS_Azure): add DefaultValue to Azure fix(azure): add DefaultValue to Azure CIS compliance Apr 3, 2024
@sergargar sergargar merged commit 5dd3c30 into master Apr 3, 2024
9 of 11 checks passed
@sergargar sergargar deleted the cis-azure-fix branch April 3, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants