Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ens): add dependencias field ENS rd2022 compliance #3701

Merged
merged 1 commit into from Apr 9, 2024
Merged

Conversation

pedrooot
Copy link
Contributor

@pedrooot pedrooot commented Apr 8, 2024

Context

This pr adds "dependencias" field to ENS rd2022 compliance

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested a review from a team as a code owner April 8, 2024 09:59
@sergargar sergargar added the backport-v3 Pending to port to Prowler v3 branch label Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (6e4dd1d) to head (c1deab3).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3701      +/-   ##
==========================================
- Coverage   85.92%   85.79%   -0.14%     
==========================================
  Files         722      722              
  Lines       22429    22431       +2     
==========================================
- Hits        19272    19244      -28     
- Misses       3157     3187      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas changed the title feat(ens): add dependencias field ENS rd2022 compliance fix(ens): add dependencias field ENS rd2022 compliance Apr 9, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @pedrooot, thanks for taking care of it! 👏

@jfagoagas jfagoagas merged commit 28b5ef9 into master Apr 9, 2024
10 of 11 checks passed
@jfagoagas jfagoagas deleted the ens-field branch April 9, 2024 06:29
@sergargar sergargar removed the backport-v3 Pending to port to Prowler v3 branch label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants