Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service_name): fix typo in ServiceName field #3723

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Apr 9, 2024

Context

This pr fix the typo in ServiceName field for eks_cluster_private_nodes_enabled

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested a review from a team as a code owner April 9, 2024 08:24
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Apr 9, 2024
jfagoagas
jfagoagas previously approved these changes Apr 9, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@pedrooot pedrooot marked this pull request as draft April 9, 2024 08:39
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (397cc26) to head (98cec72).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3723      +/-   ##
==========================================
- Coverage   85.82%   85.79%   -0.03%     
==========================================
  Files         722      722              
  Lines       22433    22435       +2     
==========================================
- Hits        19252    19248       -4     
- Misses       3181     3187       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedrooot pedrooot marked this pull request as ready for review April 9, 2024 08:55
@github-actions github-actions bot added the provider/gcp Issues/PRs related with the Google Cloud Platform provider label Apr 9, 2024
@sergargar sergargar merged commit c78c305 into master Apr 9, 2024
10 of 11 checks passed
@sergargar sergargar deleted the eks_typo branch April 9, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider provider/gcp Issues/PRs related with the Google Cloud Platform provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants